fix(agent): add missing 'Any' import in agent_loop.py#5724
Open
kh-mitya wants to merge 1 commit into
Open
Conversation
dict[str, Any] is used in _resolved_tool_event_name (L1503) and _ody_qwen_terminal_tool_summary (L1877) but Any was not imported. Fixes odysseus-dev#5723
github-actions
Bot
added
needs work
|
I just ran into this issue myself. The whole program is broken until this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit
cf4e240a("Merge verified Odysseus fixes") added two functions tosrc/agent_loop.pythat usedict[str, Any]in their type annotations, but did not addAnyto the typing import on line 15. This causes an immediateNameErroron startup — Odysseus fails to start entirely on bothmainanddevbranches.The fix is a one-line change: add
Anyto the existingfrom typing import ...statement.Target branch
devandmain.Linked Issue
Fixes #5723
Type of Change
Checklist
devHow to Test
git checkout main(ordev— same bug on both)python3 -c "from src.agent_loop import stream_agent_loop"— raisesNameError: name 'Any' is not defined