Skip to content

Commit

Permalink
Validate whole run in "validate_random_run".
Browse files Browse the repository at this point in the history
There are some race conditions in Fishtest so this will trigger
some (event) log messages. This will help us fix the race
conditions.
  • Loading branch information
vdbergh authored and ppigazzini committed Jun 10, 2024
1 parent d3e4e02 commit 2c96540
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions server/fishtest/rundb.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
nn_schema,
pgns_schema,
runs_schema,
valid_aggregated_data,
)
from fishtest.stats.stat_util import SPRT_elo
from fishtest.userdb import UserDb
Expand Down Expand Up @@ -162,12 +161,9 @@ def validate_random_run(self):
# Make sure that the run object does not change while we are
# validating it
with self.active_run_lock(run_id):
# We verify only the aggregated data since the other
# data is not synchronized and may be in a transient
# inconsistent state
validate(valid_aggregated_data, run, "run")
validate(runs_schema, run, "run")
print(
f"Validate_random_run: validated aggregated data in cache run {run_id}...",
f"Validate_random_run: validated cache run {run_id}...",
flush=True,
)
except ValidationError as e:
Expand Down

0 comments on commit 2c96540

Please sign in to comment.