Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vnni512; removed forced bmi2 on CPUS with vnni for AVX-512 #1583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maximmasiutin
Copy link
Contributor

Added vnni512; removed forced bmi2 on CPUS with vnni for AVX-512. This will allow testing of NNUE-related code for modern processors.

@noobpwnftw
Copy link
Contributor

Read comments.

@ppigazzini
Copy link
Collaborator

The PR has two problems:

  1. it will be a regression for workers tested faster with bmi2 than with avx512
  2. vnni512 and vnni256 architectures have the same conditions on props
         elif (
            "avx512vnni" in props["flags"]
            and "avx512dq" in props["flags"]
            and "avx512f" in props["flags"]
            and "avx512bw" in props["flags"]
            and "avx512vl" in props["flags"]
            and "x86-64-vnni512" in targets
        ):
            arch = "x86-64-vnni512"
        elif (
            "avx512vnni" in props["flags"]
            and "avx512dq" in props["flags"]
            and "avx512f" in props["flags"]
            and "avx512bw" in props["flags"]
            and "avx512vl" in props["flags"]
            and "x86-64-vnni256" in targets
        ):
            arch = "x86-64-vnni256"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants