sprt calculator: allow for specifying alpha and beta parameters #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the math holds, worth changing it in elo calc api as well fishtest/server/fishtest/api.py Line 563 in 12981ff |
|
changing it to be optional* and not hard-coded. |
That would depend on if the calculation for the SPRT-adjusted elo is generalized to all alpha/beta values or only 0.05. I think vdbergh would know the answer to that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generalization/expansion of the sprt calc
not particularly useful, but also wouldnt hurt
fixes contributed by @Viren who merged this pr in his fishtest fork "montytest" https://montychess.org/sprt_calc?elo-model=Normalized&elo-0=0&elo-1=2&draw-ratio=0.49&rms-bias=191&alpha=0.5&beta=0.1