Update fastchess version #2180
Merged
Update fastchess version #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Disservin Maybe put this in draft for now. I am working on some more SAN examples for your chess-lib to check, and I believe I found another issue. Will post something on the chess-lib repo by tonight. |
ppigazzini
added
worker update
|
undrafted and additional san issues from @robertnurnberg were fixed |
|
Started testing with TC 0.05+0.001 to upload many pgns: |
ppigazzini
force-pushed
the
update-fastchess-version
branch
from
9a3f099 to
6dfb3f1
Compare
ppigazzini
approved these changes
Jan 22, 2025
|
Triggered the workers update, thank you @Disservin :) |
|
Thank you too :) |
Disservin
pushed a commit
to official-stockfish/Stockfish
that referenced
this pull request
Jan 26, 2025
This PR updates the fastchess version used as part of the CI to the one used on fishtest, see official-stockfish/fishtest#2180. Also change the name/repo from fast-chess to fastchess. closes #5826 No functional change
xu-shawn
pushed a commit
to xu-shawn/Stockfish
that referenced
this pull request
Feb 2, 2025
This PR updates the fastchess version used as part of the CI to the one used on fishtest, see official-stockfish/fishtest#2180. Also change the name/repo from fast-chess to fastchess. closes official-stockfish#5826 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in the way fastchess was writing the game's pgn, mainly doubly ambiguous moves were sometimes not doubly disambiguated.
Also extract the fastchess sha into a constant at the top of the file.
Also fixes the warnings mentioned here #2169 (comment)