Remove old workaround #2194
Merged
Remove old workaround #2194
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer grow the number of games per task, it is no longer needed for fishtest performance and limits the number of workers that can be assigned e.g. to a progression test.
ppigazzini
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Looks good on DEV, PROD updating in minutes, thank you @vondele
|
Wasn’t this introduced to avoid hitting the document size limit in mongodb? |
|
hmm, I didn't recall that aspect, and also that will have improved with the ability to run larger core counts in the worker and the increased stability of the workers, but it nevertheless has become more likely. The limit is around 16MiB, but it would be good to know to what that corresponds in number of tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer grow the number of games per task,
it is no longer needed for fishtest performance
and limits the number of workers that can be assigned e.g. to a progression test.