Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Zig module icons #1085

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add Zig module icons #1085

wants to merge 2 commits into from

Conversation

Syuq
Copy link

@Syuq Syuq commented Jul 10, 2022

No description provided.

@cab-1729
Copy link
Contributor

cab-1729 commented Jul 12, 2022 •
edited
Loading

Nerd fonts as of now does not support an icon for Zig. I think it would be better to first make a pull request on their side and add such an icon prior to adding it to this project.
Unicode 21af is not a part of Nerd Fonts. According to a collaborator, this project likely does not use icons that do not come from Nerd Fonts..

On top of that, your commit seems to add the icon for a .zig hidden file instead of adding the icon to a file with the extension .zig.

This was referenced Jul 29, 2023
Open
Closed
@LGFae
Copy link

LGFae commented Aug 4, 2023 •
edited
Loading

Hello, it would appear as if Nerd Fonts has added support for zig. Specifically, gliph \ue6a9. Note that this appears to be different from the one that this PR is trying to merge.

Is there any other blockers to this, besides the gliph code being wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Syuq @cab-1729 @LGFae