Add support for Monero (XMR) stagenet addresses #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It says "unknown repository" because I deleted my fork so I can create a similar pull request at christsim/multicoin-address-validator, which appears to be better maintained at the moment :( |
|
This also needs to include validation of subaddresses. See https://github.com/monero-project/monero/blob/master/src/cryptonote_config.h for the prefixes. |
|
Thanks for the pointer, will try to implement that, it's definitely necessary. However, the original code did did not include subaddress validation as well, so IMHO subaddress validation can be added in a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from prod and testnet, Monero also has stagenet which is essentially the same thing most other cryptocurrencies call "testnet". In Monero, however, testnet is the "experimental" network and blockchain where things get released long before mainnet.