Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple 'interface' values in .toc files #430

Merged
merged 12 commits into from
Jul 18, 2024

Commits on May 10, 2024

  1. toc.clj, notes to self

    Torkus committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4452df6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. toc.clj, introduces 'interface-version-list' field.

     it contains all possible interface versions parsed from the 'interface' field.
     the current 'interface-version' field is now the first value parsed from this list.
    Torkus committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    3fb80e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. toc.clj, split 'parse-addon-toc' into '-parse-addon-toc'.

      new private fn is less strict, interpreting and extrapolating values, warning on bad values etc.
      new fn does validation and discards data if it's invalid.
      this was done so we don't have to repeat parsing steps elsewhere.
    toc.clj, the templated '## # interface' value is now considered and included in the interface-version-list.
    github-api.clj, removed duplicated parsing of :interface values in favour of that in toc.clj
    github-api.clj, order of extracted gametrack values is now deterministic.
    Torkus committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    dc5cda5 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. utils, fixed bug in interface-version-to-game-version

     - '110000' was returning '1.0.000' instead of '11.0.0'
    toc.clj, fixed bug where data would fail to valid and be discarded.
     - it was possible for multiple distinct interface-version values to become duplicate game tracks values (like [:retail :retail])
    jfx.clj, the 'WoW' (interface version) column now supports multiple values.
     - default column width values increased to accommodate them.
    Torkus committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b8794bc View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. review feedback

    Torkus committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    7eb585b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. specs.clj, replaces toc interface-version with interface-version-list

    core.clj, fixed a typo in the import/export logic and the test helper that was using :toc/game-track instead of :-toc/game-track
    toc.clj, replaced :-toc/game-track with :-toc/game-track-list
    addon.clj, a single set of toc data can now belong to many game tracks
     - this means the first instance of 'classic' toc data (for example) will be used even if multiple toc files support classic. crazy.
    tukui, curseforge, removed their 'expand-summary' implementations.
    jfx.clj, addon data detail pane now accommodates many interface values.
    toc.clj, removed a warning when the presence of a game track in the filename doesn't match the game tracks parsed from the data.
    - the user can't really do anything about it, I had at least one false-positive and with many game tracks to now check it seems needlessly expensive.
    Torkus committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d120b08 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. review feedback.

    curseforge, tukui, removes test fixtures referenced by removed code.
    Torkus committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5647bff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d09212a View commit details
    Browse the repository at this point in the history
  3. linted

    Torkus committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ad1e5b3 View commit details
    Browse the repository at this point in the history
  4. specs, source-updates, removes 'release-label' and 'interface-version'.

     these appear to have been introduced for curseforge and only used there.
    Torkus committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    274fdf4 View commit details
    Browse the repository at this point in the history
  5. review feedback

    Torkus committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1cb96c5 View commit details
    Browse the repository at this point in the history
  6. CHANGELOG

    Torkus committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    aff7341 View commit details
    Browse the repository at this point in the history