Enable sourcing ~/.bashrc #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~/.bashrc usually contains some customization to the $PATH variable, so it makes sense to source it by passing the `--login`-flag to bash. This pull request modifies the two calls to bash that are responsible for that.
ghost
mentioned this pull request
scorphus
requested changes
Jan 15, 2019
There was a problem hiding this comment.
Thanks for your valuable contribution, @samvv!
While I consider sourcing ~/.bashrc useful and necessary in many cases, I believe it should not be the default behaviour.
So, what you think about making it optional via a configuration variable (e.g. FOREIGN_ENV_SOURCE_BASHRC or FENV_SOURCE_BASHRC) and adding proper documentation?
Also, after #18 was merge, this PR conflicts with current master. Can you please resolve it?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.bashrc usually contains some customization to the $PATH variable, so it makes sense to source it by passing the
--login-flag to bash. This pull request modifies the two calls to bash that are responsiblefor that.