fix: stop temperature forecast falling back to PV power cache - #285
Merged
Conversation
Temperature and PV power forecasts share one Akkudoktor client method, error handler, cache, and failure counter. A failed temperature request could return cached PV watts mislabeled as Celsius, and the shared failure counter reset on every successful power fetch before it could reach the threshold that triggers the 15C default. Give temperature its own cache and failure counter, thread the fetch target through the error handler so it selects the matching one, stop feeding fallback data back through the raw-JSON processing step, and add a range check as a fail-safe. Fixes: #276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temperature and PV power forecasts share one Akkudoktor client method, error handler, cache, and failure counter. A failed temperature request could return cached PV watts mislabeled as Celsius, and the shared failure counter reset on every successful power fetch before it could reach the threshold that triggers the 15C default.
Give temperature its own cache and failure counter, thread the fetch target through the error handler so it selects the matching one, stop feeding fallback data back through the raw-JSON processing step, and add a range check as a fail-safe.
Fixes: #276