Improve browser selection in WebAuthenticationProvider #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation for the packages selected as browsers.
I encountered an issue on a device with Google Chrome disabled and another browser set as the default. Also, that device has an application installed that appears when querying for
ACTION_CUSTOM_TABS_CONNECTIONbut is not a browser. This app is listed first and is returned as a valid browser, but it cannot be used to open a URL.To address this, each package is checked for validity as a browser using the
isBrowserPackagefunction.