Skip to content

Update dependencies (no router-dom) #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update dependencies (no router-dom) #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e86b1e2
Update dependencies for React 18. react-router-dom is not updated bec…
Oct 18, 2024
2b19851
Revert prestart script.
Oct 18, 2024
cae8933
Update root package.json dependencies.
Oct 18, 2024
1110b00
Merge branch 'master' into update-dependencies-no-router-dom
Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions custom-login/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@
},
"dependencies": {
"@okta/okta-auth-js": "*",
"@okta/okta-react": "^6.7.0",
"@okta/okta-react": "^6.9.0",
"@okta/okta-signin-widget": "^6.7.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router-dom": "5.2.0",
"semantic-ui-css": "2.4.1",
"semantic-ui-react": "2.0.3",
"text-encoding": "0.7.0"
"semantic-ui-css": "2.5.0",
"semantic-ui-react": "2.1.5",
"@sinonjs/text-encoding": "0.7.3"
},
"devDependencies": {
"@vitejs/plugin-react": "^1.3.2",
"@vitejs/plugin-react": "^2.2.0",
"dotenv": "^16.0.0",
"vite": "^2.9.15"
"vite": "^3.2.11"
}
}
6 changes: 5 additions & 1 deletion custom-login/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ export default defineConfig(( { command } ) => {
},
build: {
rollupOptions: {
// always throw with build warnings
// Allow warnings related to circular dependencies in semantic-ui-react.
// https://github.com/Semantic-Org/Semantic-UI-React/issues/3472
onwarn (warning, warn) {
if (warning.code === "CIRCULAR_DEPENDENCY" && warning.message.includes("semantic-ui-react")) {
return;
}
warn('\nBuild warning happened, customize "onwarn" callback in vite.config.js to handle this error.');
throw new Error(warning);
}
Expand Down
20 changes: 10 additions & 10 deletions okta-hosted-login/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"preview": "vite preview"
},
"dependencies": {
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-router-dom": "5.2.0",
"@okta/okta-auth-js": "*",
"semantic-ui-css": "2.4.1",
"semantic-ui-react": "2.0.3",
"text-encoding": "0.7.0",
"@okta/okta-react": "^6.7.0"
"@okta/okta-react": "^6.9.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router-dom": "5.2.0",
"semantic-ui-css": "2.5.0",
"semantic-ui-react": "2.1.5",
"@sinonjs/text-encoding": "0.7.3"
},
"devDependencies": {
"@vitejs/plugin-react": "^1.3.2",
"dotenv": "^16.0.0",
"vite": "^2.9.15"
"@vitejs/plugin-react": "^4.3.2",
"dotenv": "^16.4.5",
"vite": "^5.4.9"
}
}
2 changes: 1 addition & 1 deletion okta-hosted-login/src/polyfills.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

// polyfill TextEncoder for IE Edge
import { TextEncoder } from 'text-encoding';
import { TextEncoder } from '@sinonjs/text-encoding';

if (typeof window.TextEncoder === 'undefined') {
window.TextEncoder = TextEncoder;
Expand Down
6 changes: 5 additions & 1 deletion okta-hosted-login/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ export default defineConfig(( { command } ) => {
},
build: {
rollupOptions: {
// always throw with build warnings
// Allow warnings related to circular dependencies in semantic-ui-react.
// https://github.com/Semantic-Org/Semantic-UI-React/issues/3472
onwarn (warning, warn) {
if (warning.code === "CIRCULAR_DEPENDENCY" && warning.message.includes("semantic-ui-react")) {
return;
}
warn('\nBuild warning happened, customize "onwarn" callback in vite.config.js to handle this error.');
throw new Error(warning);
}
Expand Down
Loading