Uncharge glory #5732
Open
Uncharge glory #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to uncharge amulet of glory (6)'s. This will be useful for players chasing the eternal glory at the fountain of ruins. Closes oldschoolgg#3825
…into uncharge-glory
gc
requested changes
Apr 22, 2024
There was a problem hiding this comment.
I think id be okay with a way to instantly convert them to uncharged with some small fee, assuming in real osrs youd just sell the charged ones and buy uncharged ones. I guess irons still need a way to do it though. Also just make sure its not possible to charge a negative amount.
| const user = await mUserFetch(userID); | ||
| let loot = new Bank().add('Amulet of glory', quantity); | ||
|
|
||
| const amnt = loot.amount('Amulet of glory'); |
There was a problem hiding this comment.
This variable looks pointless, just use quantity?
| type: 'GloryUncharging' | ||
| }); | ||
|
|
||
| await user.removeItemsFromBank(new Bank().add('Amulet of glory (6)', quantity)); |
There was a problem hiding this comment.
Remove before creating the activity. Also the cleaner way to do it is: const cost = ... if (!user.owns(cost))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to uncharge amulet of glory (6)'s. This will be useful for players chasing the eternal glory at the fountain of rune.
Closes #3825