Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd round of adding to Cyr's works in bank project #5758

Open
wants to merge 9 commits into
base: bso
Choose a base branch
from

Conversation

I-am-TURBO
Copy link
Contributor

@I-am-TURBO I-am-TURBO commented Mar 7, 2024

Description:

trying to help cyr out with his works in bank project #5659.

Changes:

These items will work in bank:

  • Fishing Contest — Fishing master cape, Ring of luck & Crystal fishing rod
  • Hunter master cape
  • Mining — Mining master cape
  • Farming — Ring of endurance
  • ODS — Runecraft master cape

Reverts made (need to be equipped)

  • water & fire tomes
  • strength master cape (listed in monkey rumble)
  • Thieves' armband (it was set to work from Bank)

Other checks:

  • I have tested all my changes thoroughly.

@themrrobert
Copy link
Contributor

We're definitely not making the combat stuff work from bank as of now.

Also, I think the tome of water/fire should maybe still require being equipped?

I don't see any changes for Mining master cape? But mining is a much more complicated thing to fix, so I'd suggest you leave that one alone.

The rest seem ok

@I-am-TURBO
Copy link
Contributor Author

We're definitely not making the combat stuff work from bank as of now.

Also, I think the tome of water/fire should maybe still require being equipped?

I don't see any changes for Mining master cape? But mining is a much more complicated thing to fix, so I'd suggest you leave that one alone.

The rest seem ok

okay ill fix

@I-am-TURBO
Copy link
Contributor Author

I-am-TURBO commented Mar 9, 2024

We're definitely not making the combat stuff work from bank as of now.

Also, I think the tome of water/fire should maybe still require being equipped?

I don't see any changes for Mining master cape? But mining is a much more complicated thing to fix, so I'd suggest you leave that one alone.

The rest seem ok

I can switch back the strength mastercape if that was how you wanted it in Monkey Rumble but I read in your PR that thieves armband is not to be set to work from bank but it was

Reverts made (need to be equipped)

  • water & fire tomes
  • strength master cape (listed in monkey rumble)
  • Thieves' armband (it was set to work from Bank)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants