Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skill cape perks to comp & master cape #5917

Open
wants to merge 5 commits into
base: bso
Choose a base branch
from

Conversation

nwjgit
Copy link
Contributor

@nwjgit nwjgit commented Jun 12, 2024

Description:

Add skill cape perks to comp & master capes and clean up similarItems file.
Polls for community support:
https://discord.com/channels/342983479501389826/1032668754561224734/1250110507311173634
https://discord.com/channels/342983479501389826/1032668754561224734/1250191517071704125

Changes:

  • Make higher tiered skill related capes always receive the lower capes perks.
    • example: comp cape will receive all master cape and skill cape perks, gathers cape will receive all appropriate master cape and skill cape perks, woodcutting master cape will receive woodcutting skill cape perks, max cape receives all skill cape perks.
  • Create skill cape and master cape similar items dynamically and remove old code.
  • add expert capes to skill capes to help make the dynamic similaritem list.
  • add quest cape sim items
  • did a little file clean up for similaritems
  • Correct the comp cape not receiving achievement/music cape perks. Comp counted as trimmed version but the code checks for non trimmed versions when applying the boosts which would cause the perks to not actually work with comp cape. Updated tests aswell.
  • renamed allMasterCapesBank to compCapeCreatableBank and added a note above the refunded items for comp cape.

Other checks:

  • I have tested all my changes thoroughly.
  • This was also tested with testers in the testing discord.
    Console log of the dynamic list created:
    Code_vaXc2sBhfw
    Example of adding to an item that already exists:
    Code_mHpAUwS25G

@nwjgit nwjgit added the BSO Bot School Old label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSO Bot School Old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant