Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp #81

Closed
wants to merge 3 commits into from
Closed

Temp #81

wants to merge 3 commits into from

Conversation

oldwinter
Copy link
Owner

No description provided.

max_tokens: 1024
MAX_PATCH_LENGTH: 1024 # if the patch/diff length is large than MAX_PATCH_LENGTH, will be ignored and won't review. By default, with no MAX_PATCH_LENGTH set, there is also no limit for the patch/diff length.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码差异中的改动是将max_tokens的值从10000修改为1024,将MAX_PATCH_LENGTH的值从10000修改为1024。这些修改看起来更加规范,符合常见的编码规范和最佳实践。没有发现混淆或不规范之处。

# input="texts",
# chunk_size=1
show_progress_bar=True,
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

经过检查,以下是代码差异中可能存在混淆或不规范之处:

  1. 在文本行 +from langchain.document_loaders import ObsidianLoader 中,引入了 ObsidianLoader,但在后续代码中没有使用到该模块。

  2. 在文本行 +loader = ObsidianLoader("/Users/yingtu/知识库/ingtube") 中,将一个目录路径传递给 ObsidianLoader 的构造函数,但对于读取目录,通常需要使用方法来获取目录下的文件列表。

  3. 在文本行 +# llm(documents1[0].page_content) 中,添加了一个注释符号 #,这可能是一些特定编辑环境的注释方式,但这样的注释符号通常是不会提交到版本控制系统中的。

  4. 在文本行 +embeddings = OpenAIEmbeddings(...) 中,实例化了一个 OpenAIEmbeddings 对象,但其中的 client 参数为空字符串,这可能导致接口调用失败或产生错误。

以上是可能存在混淆或不规范之处的问题。如有需要,请进一步确认和修正这些问题。

@oldwinter oldwinter closed this Aug 9, 2023
@oldwinter oldwinter deleted the temp branch August 23, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant