Fix compilation errors with new SDK; Fix defaults for new SDK

[iw2lsi]

Hi Oleg...

I've basically done the same changes as you for IDF v4.0 and it seems to work here... maybe you just forgot to review de defaults ?

[olegv142]

Hello, Thank you. I didn't know about changing defaults. Will check gain чт, 13 мая 2021 г. в 17:04, iw2lsi ***@***.***>:

…

Hi Oleg... I've basically done the same changes as you for IDF v4.0 and it seems to work here... maybe you just forgot to review de defaults ? ------------------------------ You can view, comment on, or merge this pull request online at: #3 Commit Summary - Fix compilation errors with new SDK; Fix defaults for new SDK File Changes - *M* main/spp_vfs_acceptor.c <https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-623fa79ca0abd58cfa032bacec585c841bfe7814213b45e52fe2faabfd5875cc> (3) - *M* sdkconfig.defaults <https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-828575c709a84e0dfe49845ee9030bcc01f12e9220029d91761990595de011a1> (9) Patch Links: - https://github.com/olegv142/esp32-bt-serial/pull/3.patch - https://github.com/olegv142/esp32-bt-serial/pull/3.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACMQMKSGOES6DDJMDCGM2MTTNPL73ANCNFSM442TSLWA> .

[olegv142]

The things are not so simple and actually quite bad. The build system is smart enough to recognize old config parameters. But yet the code does not work printing the following error to serial console: BT_BTC: btc_spp_vfs_register SPP have not been init To fix it one can move esp_spp_vfs_register() call as was done in commit espressif/esp-idf@478cef9 After that the BT adapter starts to work somehow. Running echo test I see serious speed degradation (2 times) in comparison to the old SDK. Besides there are errors constantly being printed to serial console: BT_L2CAP: l2cab is_cong_cback_context Seems that they are related to congestion causing the speed degradation. So for now the new SDK looks pretty unusable. чт, 13 мая 2021 г. в 17:04, iw2lsi ***@***.***>:

…

Hi Oleg... I've basically done the same changes as you for IDF v4.0 and it seems to work here... maybe you just forgot to review de defaults ? ------------------------------ You can view, comment on, or merge this pull request online at: #3 Commit Summary - Fix compilation errors with new SDK; Fix defaults for new SDK File Changes - *M* main/spp_vfs_acceptor.c <https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-623fa79ca0abd58cfa032bacec585c841bfe7814213b45e52fe2faabfd5875cc> (3) - *M* sdkconfig.defaults <https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-828575c709a84e0dfe49845ee9030bcc01f12e9220029d91761990595de011a1> (9) Patch Links: - https://github.com/olegv142/esp32-bt-serial/pull/3.patch - https://github.com/olegv142/esp32-bt-serial/pull/3.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACMQMKSGOES6DDJMDCGM2MTTNPL73ANCNFSM442TSLWA> .

[iw2lsi]

Hi Oleg... which version of the SDK are you using ? I admit I've done a very quick test yesterday, but for me it was working and I see no errors on the console log... Giampaolo Il giorno ven 14 mag 2021 alle ore 10:56 Oleg ***@***.***> ha scritto:

…

The things are not so simple and actually quite bad. The build system is smart enough to recognize old config parameters. But yet the code does not work printing the following error to serial console: BT_BTC: btc_spp_vfs_register SPP have not been init To fix it one can move esp_spp_vfs_register() call as was done in commit espressif/esp-idf@478cef9 After that the BT adapter starts to work somehow. Running echo test I see serious speed degradation (2 times) in comparison to the old SDK. Besides there are errors constantly being printed to serial console: BT_L2CAP: l2cab is_cong_cback_context Seems that they are related to congestion causing the speed degradation. So for now the new SDK looks pretty unusable. чт, 13 мая 2021 г. в 17:04, iw2lsi ***@***.***>: > Hi Oleg... > > I've basically done the same changes as you for IDF v4.0 and it seems to > work here... maybe you just forgot to review de defaults ? > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #3 > Commit Summary > > - Fix compilation errors with new SDK; Fix defaults for new SDK > > File Changes > > - *M* main/spp_vfs_acceptor.c > < https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-623fa79ca0abd58cfa032bacec585c841bfe7814213b45e52fe2faabfd5875cc > > (3) > - *M* sdkconfig.defaults > < https://github.com/olegv142/esp32-bt-serial/pull/3/files#diff-828575c709a84e0dfe49845ee9030bcc01f12e9220029d91761990595de011a1 > > (9) > > Patch Links: > > - https://github.com/olegv142/esp32-bt-serial/pull/3.patch > - https://github.com/olegv142/esp32-bt-serial/pull/3.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#3>, or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ACMQMKSGOES6DDJMDCGM2MTTNPL73ANCNFSM442TSLWA > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAODQQCIPBIYEI5BCORXQI3TNTQSFANCNFSM442TSLWA> .

[olegv142]

The problems mentioned above were discovered on the latest release 4.2.1 (as well as on the SDK master branch).
I have checked several SDK releases and found that the last one that worked well with original code is v3.2.5.
Yet it shows errors BT_L2CAP: l2cab is_cong_cback_context
But looking to the code I can guess that they are not errors actually.