Skip to content

Add LICENSE-APACHE and LICENSE-MIT files.#363

Open
anforowicz wants to merge 1 commit intooli-obk:mainfrom
anforowicz:add-license-files
Open

Add LICENSE-APACHE and LICENSE-MIT files.#363
anforowicz wants to merge 1 commit intooli-obk:mainfrom
anforowicz:add-license-files

Conversation

@anforowicz
Copy link

PTAL?


This commit follows the advice from the Rust API guidelines (https://rust-lang.github.io/api-guidelines/necessities.html) which suggest to

add [...] LICENSE-MIT in the repository root,
containing the text of the licenses (which you can obtain, for
instance, from choosealicense.com, for Apache-2.0 and MIT).

This commit helps software projects like Chromium to fullfil their requirements for explicitly covering license information for all of their dependencies (e.g. see https://crbug.com/369075726).

The license files (and copyright notices within, if any) have been copied from https://github.com/rust-lang/rust where AFAIK the ui_test crate has originated from.


It would really help me if you could merge this PR and then publish a new version of the crate to crates.io. Thanks in advance!


TODO (check if already done)

  • Add tests
    • Comment/response by @anforowicz: not applicable - this PR doesn't affect any functionality
  • Add CHANGELOG.md entry
    • Comment/response by @anforowicz: this is a minor/logistical change that doesn't seem worth a note in CHANGELOG.md (?)
  • Bumped minor version and committed lockfiles in case a release is desired.
    • Comment/response by @anforowicz: yes, a new release would be much appreciated

This commit follows the advice from the Rust API guidelines
(https://rust-lang.github.io/api-guidelines/necessities.html)
which suggest to

> add [...] LICENSE-MIT in the repository root,
> containing the text of the licenses (which you can obtain, for
> instance, from choosealicense.com, for Apache-2.0 and MIT).

This commit helps software projects like Chromium to fullfil their
requirements for explicitly covering license information for all of
their dependencies (e.g. see https://crbug.com/369075726).

The license files (and copyright notices within, if any) have been
copied from https://github.com/rust-lang/rust where AFAIK the `ui_test`
crate has originated from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant