Update code style formatting configuration (clang-format) #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-format --style=Google --dump-config > .clang-format Adjusted ColumnLimit to 100
Usage: cmake --build . --target format
|
Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks |
|
Still relevant and the refactoring doesn't have much of an impact on this work, except that the style should be enforced in all repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Google style as of clang-format v10.0.1
ColumnLimitraised from 80 to 100 (unclear where 120 came from)CMake integration inspired by https://arcanis.me/en/2015/10/17/cppcheck-and-clang-format#clang-cmake
Formatting the code with
cmake --build . --target formatappears to affect all files. It looks like the current code style is different from Google's in various smaller aspects.