Skip to content

Conversation

@eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Feb 10, 2020

Replaces fbjs/lib/shallowEqual with shallow-equal#shallowEqualObjects.
fbjs is not intended for usage outside of facebook and pulls in outdated dependencies (e.g. isomorphic-fetch).

It doesn't use same-value equality as of yet (proposed in moroshko/shallow-equal#17) but it seems like this isn't an issue here since we control what kind of values we compare.

@oliviertassinari
Copy link
Owner

I remember a couple of back and forth on this problem two years ago. I think fbjs was used at some point to use the same dependency as React. It's probably no longer used :)

@oliviertassinari oliviertassinari merged commit 9038d53 into oliviertassinari:master Feb 10, 2020
@eps1lon
Copy link
Contributor Author

eps1lon commented Feb 10, 2020

I remember a couple of back and forth on this problem two years ago. I think fbjs was used at some point to use the same dependency as React. It's probably no longer used :)

They dropped it in 16.5: facebook/react@8e87c13

@oliviertassinari
Copy link
Owner

👌

@oliviertassinari
Copy link
Owner

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants