docs(example): add description of fallback handling #64
Conversation
| // | ||
| // offline-fallback.html should be defined in servierWorkerOption.assets | ||
| // to ensure it's always cached. | ||
| return global.caches.match('./offline-fallback.html') |
There was a problem hiding this comment.
Yes, this default makes a lot more sense to me. In order for it to work though, the offline-fallback.html page needs to be added to the cache first. Could you update line 15 accordingly.
I don't agree that serviceWorkerOptions.assets is, necessarily the right place to make sure the fallback page is cached. Perhaps define a constant in this file that defines the fallback page URL. For documentation purposes, something like this might work:
// Page to fallback to in case the resource we are trying to navigate to can't be found on
// either cache or network. Hint: Use `transformOptions` to add additional information to
// serviceWorkerOption
const FALLBACK_PAGE = serviceWorkerOption.fallbackPage || './offline-fallback.html';There was a problem hiding this comment.
Sure! But maybe we shall skip the serviceWorkerOption.fallbackPage part to keep it simplier? If we do that I think we can skip the descriptional comment above the FALLBACK_PAGE declaration. I think it's self describing if the reader follows the code.
2 participants
Closes #58