Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

FLOW-923 | f-select options navigation through arrow keys #140

Closed
wants to merge 3 commits into from

Conversation

mayankfulera
Copy link
Contributor

Checklist for raising a PR

  • Gone through UX documnetation for adding new features.
  • All necessary unit tests covered.
  • Required comments added for generating component manifest file? you can find details here
  • Did you check the contributing doc?
  • Did you check the existing issues for similar queries?

Describe your PR

Implementing option navigation in f-select using arrow keys:
up arrow key → to move up
down arrow key → to move down
enter key → to select the option
esc key → to exit the dropdown

Add additional question here

  • Yes
  • No
  • NA

@datapipes-robot
Copy link

@mayankfulera: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@datapipes-robot
Copy link

@mayankfulera: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants