-
Notifications
You must be signed in to change notification settings - Fork 5
Component registration updated #268
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
/// <reference types="vite/client" /> | ||
|
||
import { ConfigUtil } from "@ollion/flow-core-config"; | ||
import { version } from "../package.json"; | ||
import { LitElement } from "lit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think barrel files are not handled when doing tree shaking https://vitejs.dev/guide/performance#avoid-barrel-files
We should try enabling sideEffects
option in package.json and check if Vite can tree shake unused components - https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try publishing a beta version, and check if vite handles this correctly
Checklist for raising a PR
Describe your PR
@ollion/flow-core
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-code-editor
[2.0.0] - 2024-04-20
Major/Breaking Changes
@ollion/flow-form-builder
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-lineage
[4.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-log
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-md-editor
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-table
[3.0.0] - 2024-04-29
Major/Breaking Changes