Persist XKB-only installer layouts (Thai) into vconsole.conf - #141
Open
kengggg wants to merge 1 commit into
Open
Persist XKB-only installer layouts (Thai) into vconsole.conf#141kengggg wants to merge 1 commit into
kengggg wants to merge 1 commit into
Conversation
Picker values that kbd does not ship (Thai today) used to be rejected, so the installed system stayed US. Write KEYMAP=us and XKBLAYOUT=<choice> for names in OMARCHY_XKB_ONLY_LAYOUTS, and loadkeys us on the live console so LUKS stays Latin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some layouts the shared
setup-form.shpicker now offers are XKB layouts, not kbd console keymaps (thtoday).configure_keyboardused to return False for those, so the installedvconsole.confnever gotXKBLAYOUTand Hyprland fell back to US.For names listed in
OMARCHY_XKB_ONLY_LAYOUTS, writeKEYMAP=us(so systemd-firstboot and LUKS stay Latin) andXKBLAYOUT=<choice>. Unknown names that are not on that list still return False. The live configuratorloadkeysusesomarchy_console_keymap_forfrom the vendored form so Thai keeps a US console during password entry.Depends on omacom/omarchy#9358 (adds the picker row and
OMARCHY_XKB_ONLY_LAYOUTS).Testing
python test/unit/test_keyboard.py— realconfigure_keyboard+systemd-firstboot --root:KEYMAP=<itself>thwritesKEYMAP=us/XKBLAYOUT=thand keeps FONTdefinitely-not-a-keymapstill refused./test/allgreen (66 Python tests + existing shell unit tests)ISO QEMU (
./bin/omarchy-iso-make --local-source ../omarchythen./bin/omarchy-iso-boot) was not run here: noqemu-system-x86_64. The install persist path this PR owns isconfigure_keyboard, which the unit tests drive against a fake root with the realsystemd-firstboot.