Prefer the live device name when labeling Bluetooth devices - #10191
Open
njos-444-navelin wants to merge 1 commit into
Open
Prefer the live device name when labeling Bluetooth devices#10191njos-444-navelin wants to merge 1 commit into
njos-444-navelin wants to merge 1 commit into
Conversation
deviceLabel favored device.deviceName over device.name. deviceName mirrors BlueZ's Name property, which is set once from the device's advertisement and persisted to BlueZ's own on-disk device record — it never changes, not even across a shell restart or reboot. name mirrors BlueZ's Alias, the property a rename actually writes. Swap the priority so a rename reaches the label, and update the test that encoded the old priority. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
njos-444-navelin
force-pushed
the
fix-bluetooth-panel-rename
branch
from
September 4, 2026 15:23
a98e0a5 to
ffd37c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after restarting the bar or shell, not after rebooting.
deviceLabelfavoreddevice.deviceNameoverdevice.name.deviceNamemirrors BlueZ'sNameproperty, which is set oncefrom the device's advertisement and persisted to BlueZ's own
on-disk device record — it never changes.
device.namemirrorsBlueZ's
Alias, the property a rename actually writes.deviceNamekept as a fallback for the (rare) case wherenameis unset.
Test plan
test/shell.d/bluetooth-test.sh, which previously assertedthe old priority, to cover both the rename-wins and the
deviceName-fallback cases.
bash test/shell.d/bluetooth-test.shpasses.🤖 Generated with Claude Code