Parse url raise exception #472
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471.
TODO: fix lots of tests!
We should also consider handling the scenario described there, where user expects one OME-Zarr format but gets a different one.
See #468 where we remove handling of mismatching ome-zarr formats, because we don't want to re-create a store.
probably
parse_url()with No format specified should be happy to read any format, but IF you specify a format, it MUST match.This would be similar to the strategy used for
write_image()etc where the default format isNone(format will be chosen based on zarr group) but if you specify a format that is incompatible, you get an exception.e.g.