forked from glencoesoftware/omero-zarr-pixel-buffer
-
Notifications
You must be signed in to change notification settings - Fork 3
Support for Zarr v3 (resp NGFF 0.5) #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dominikl
wants to merge
17
commits into
ome:master
Choose a base branch
from
dominikl:v0_5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased to master after glencoesoftware#28 was merged. |
Rebased to master after glencoesoftware#27 was merged. |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimise changes to the ZarrPixelBuffer/Service itself v2 zarrs will still be accessed via jzarr and v3 will be accessed via zarr-java. ZarrPixelBuffer/Service only uses the interfaces ZarrPath (with ZarrPathv2/v3 implementations) and ZArray (with ZArrayv2/v3 implementations). As a future task could investigate to get rid of jzarr and replace completely with zarr-java.
Todo: Point tests to valid v2/ngff0.4 and v3/ngff0.5 zarrs (there's no way to create valid ngff 0.5 zarrs yet).