Replace unmaintained dependency git.cs.nctu.edu.tw/calee/sctp with github.com/ishidawataru/sctp #517
+23
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces an unmaintained SCTP dependency git.cs.nctu.edu.tw/calee/sctp with the actively maintained github.com/ishidawataru/sctp library. The changes simplify the NGAP handler interface and remove SCTP notification handling functionality.
- Replaced unmaintained SCTP library with
github.com/ishidawataru/sctp - Simplified NGAPHandler from struct to function type
- Removed SCTP notification handling and related configuration
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Updates dependency from unmaintained SCTP library to github.com/ishidawataru/sctp |
| service/init.go | Simplifies NGAP handler instantiation to match new function signature |
| ngap/service/service.go | Refactors handler interface, removes notification handling and timeout configuration |
| ngap/dispatcher.go | Removes SCTP notification handler function and unused imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gab-arrobo
changed the title
gab-arrobo
changed the title
thakurajayL
reviewed
Sep 10, 2025
| HandleMessage: ngap.Dispatch, | ||
| HandleNotification: ngap.HandleSCTPNotification, | ||
| } | ||
| ngapHandler := ngap_service.NGAPHandler(ngap.Dispatch) |
There was a problem hiding this comment.
Is it like new sctp module does not support notification? What happens in client (i.e. gNodeB) crashes/restarts
gab-arrobo
force-pushed
the
replace-unmantained-dep
branch
from
5b500cf to
9c20453
Compare
gab-arrobo
force-pushed
the
replace-unmantained-dep
branch
from
dcc78f7 to
c0beee5
Compare
…thub.com/ishidawataru/sctp Signed-off-by: Arrobo, Gabriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.