INF-935 (work on publishing docs)

[dafATonf]

Private TEst bed --- DO NOT MERGE

[onf-cla-manager]

Hi @dafATonf, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID dafATonf to the agreement.

For more information or help:"
https://wiki.opennetworking.org/x/BgCUI

[gab-arrobo]

Hi @dafATonf, I was running some experiments to understand why the Publish_docs action fails and after a couple experiments, I realized that it makes sense to fail with the error No matching refs found! and this is because you are making this action to be executed for push in your dev-daf branch. However, this branch is not "allowed" in the conf.py. So, if you add the dev-daf branch into the conf.py file, the action will succeed and this is why the action should only be executed in push for master and sdcore-#.# branches. Please take a look at my test-gab branch in [here](No matching refs found!). the only thing that is not clear to me is why the Action did not fail because I do not have any credentials configured in my fork to be able to push the changes to the sdcore documentation website. So, I was expecting this action to fail but, as you can see in my repo, the action successfully completes, which is not correct because the changes were not pushed to the documentation website.

[gab-arrobo]

Hi @dafATonf, I was running some experiments to understand why the Publish_docs action fails and after a couple experiments, I realized that it makes sense to fail with the error No matching refs found! and this is because you are making this action to be executed for push in your dev-daf branch. However, this branch is not "allowed" in the conf.py. So, if you add the dev-daf branch into the conf.py file, the action will succeed and this is why the action should only be executed in push for master and sdcore-#.# branches. Please take a look at my test-gab branch in [here](No matching refs found!). the only thing that is not clear to me is why the Action did not fail because I do not have any credentials configured in my fork to be able to push the changes to the sdcore documentation website. So, I was expecting this action to fail but, as you can see in my repo, the action successfully completes, which is not correct because the changes were not pushed to the documentation website.

Now, the publish action in my fork (https://github.com/gab-arrobo/sdcore-docs/tree/test-gab) is working as expected (fails when the rsync script is not successful). @dafATonf how would you like me to proceed? Append my changes to your PR or open a PR with my changes?

[gab-arrobo]

superseded by #12