Fix warning C4702: unreachable code

omf2097 · Nov 26, 2024 · 01436af · 01436af
1 parent 513e27c
commit 01436af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -80,6 +80,8 @@ if(MSVC)
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /we4701")
     # C4668: undefined symbol used as compiler directive (will evaluate to 0).
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /we4668")
+    # C4702: unreachable code
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /we4702")
 else()
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wno-unused-parameter -Wformat -pedantic -Wvla")
     set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -ggdb -Werror -fno-omit-frame-pointer")

diff --git a/src/game/utils/nat.c b/src/game/utils/nat.c
@@ -40,8 +40,9 @@ bool nat_create_upnp_mapping(nat_ctx *ctx, uint16_t int_port, uint16_t ext_port)
         // like overly short lifetimes
         return false;
     }
-#endif
+#else
     return false;
+#endif
 }
 
 bool nat_create_pmp_mapping(nat_ctx *ctx, uint16_t int_port, uint16_t ext_port) {
@@ -70,8 +71,9 @@ bool nat_create_pmp_mapping(nat_ctx *ctx, uint16_t int_port, uint16_t ext_port)
         // TODO handle some errors here
         return false;
     }
-#endif
+#else
     return false;
+#endif
 }
 
 bool nat_create_mapping(nat_ctx *ctx, uint16_t int_port, uint16_t ext_port) {