Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC Warning cleanup, /WX (Werror), and misc. fixes #790

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Nopey
Copy link
Contributor

@Nopey Nopey commented Nov 26, 2024

  • DEBUGMODE is now defined on MSVC debug builds
  • VS_DEBUGGER_ENVIRONMENT now tells game where to find the resources and shaders, needed because build\resources is not next to build\Debug\openomf.exe (another solution I used previously was to copy the resources into build\Debug, but that's messy)
  • Warnings are now either: silenced, treated as errors, and or fixed.

Enabling and fixing C4668 may be a bit silly, but I was feeling guilty about my habit of writing #if XYZ instead of #ifdef XYZ (where XYZ is maybe-defined, like __APPLE__)

implicit lossy conversions

The following two warnings are now be disabled, and are comparable to GCC's -Wconversion; -Wconversion is not enabled on master branch. Banning implicit lossy conversions is a good idea for another time, but fixing them will generate a lot of line diff noise.

C4244: implicit conversion, possible loss of data
C4267: implicit conversion from size_t, possible loss of data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants