Add Excel OpenSpout exporter #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 36 36
Lines 956 956
=======================================
Hits 903 903
Misses 53 53 ☔ View full report in Codecov by Sentry. |
mhvis
force-pushed
the
maarten-openspout2
branch
from
5eef9c5
to
4754054
Compare
|
Looks good, thanks 👍 |
|
Published as well now, sorry. |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpSpreadsheet is not very performant for larger files. Here is a suggestion to add OpenSpout as an additional exporter. It performs ~40x faster in my test setup.
HTML tags are stripped from the input data because there is no rich text support in OpenSpout.