Column filter #336
Column filter #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 37 37
Lines 968 968
=======================================
Hits 915 915
Misses 53 53 ☔ View full report in Codecov by Sentry. |
|
@kathibeepboop What is the reason you closed this PR? |
I've decided to close this merge request due to the conditions set by the repository owner, who has requested a change in the package name before proceeding with any review. Given that this change requires significant effort and I am already using my fork, I believe it's more practical for me to continue with my current setup. P.S. if you want to have a working column sorting, feel free to use the fork (It won´t be maintained very well, just fixing as soon as I need something, like symfony 7,8, php9 or whatever will come) composer require fluxter/datatables-bundle |
|
Do you mind if I re-submit your PR with the proposed changes? |
|
Absolutly not! Feel free to use everything i did in the PR or in my fork as welll |
|
I'm happy to review anything, it's just that I cannot accept changes that would break the release process of the bundle like the name 😉 I've actually RC'd an update yesterday for ORM 3 and DBAL 4 compatibility. We might want to shove this change in the 0.9 as well. |
I changed the templates so the column filter will work again.
Also i changed the behavior of a text search, that will search now for parts not the exact value.
Feel free to merge this to have this functionality back!