Ignore PHPStan assuming incorrect return type in AutomaticQueryBuilder #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPStan uses the return type specified in the PHPDoc of the interface \Doctrine\Persistence\Mapping\ClassMetadata (which makes sense). However, the implementation at \Doctrine\ORM\Mapping\ClassMetadata may return null. I don't know the proper way to fix this so I just ignored it here. (But feel free to reject this PR.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 37 37
Lines 1000 1000
=======================================
Hits 947 947
Misses 53 53 ☔ View full report in Codecov by Sentry. |
|
I'm not sure why the pipeline still fails here. I can't replicate it locally. So I won't look into it any further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan uses the return type specified in the PHPDoc of the interface \Doctrine\Persistence\Mapping\ClassMetadata (which makes sense).
However, the implementation at \Doctrine\ORM\Mapping\ClassMetadata may return null.
I don't know the proper way to fix this so I just ignored it here. (But feel free to reject this PR.)