Skip to content
CI

Fix SonarCloud "Cognitive Complexity" warning in CreditCardPaymentController #603

Sign in to view logs

Fix SonarCloud "Cognitive Complexity" warning in CreditCardPaymentController

Fix SonarCloud "Cognitive Complexity" warning in CreditCardPaymentController #603

Triggered via pull request June 17, 2024 05:25
@vault087vault087
synchronize #296
fix/MIT-2554-SonarCloud-CreditCard
Status Failure
Total duration 4m 7s
Artifacts 1

main.yml

on: pull_request
test
3m 18s
test
lint
33s
lint
Sonar scan
35s
Sonar scan
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 4 warnings
lint: OmiseSDKTests/Helpers/String+JSON.swift#L30
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint: OmiseSDKTests/Helpers/SampleData.swift#L65
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint: OmiseSDKTests/ClientTests.swift#L57
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint: OmiseSDKTests/ClientTests.swift#L91
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint: OmiseSDKTests/3DS/SHA512Tests.swift#L11
Superfluous Disable Command Violation: SwiftLint rule 'multiline_literal_brackets' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
lint: OmiseSDKTests/Source and Token JSON Codable Tests/SourceTests.swift#L14
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint: OmiseSDK/Sources/3DS/NetceteraThreeDSController.swift#L107
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "artifact". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Sonar scan
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/download-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Artifacts

Produced during runtime
Name Size
artifact Expired
536 KB