Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop -> Master (SonarCloud Warnings Fixes) #295

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

vault087
Copy link

@vault087 vault087 commented May 31, 2024

Fix SonarCloud warning in "Refactor this function to reduce its Cognitive Complexity from [xx] to the 15 allowed" in

  • OmiseError
  • NetceteraThreeDSController
  • CardExpiryDateTextField
  • CreditCardPaymentController

Fixed SonarCloud issues of type “Add a nested comment explaining why this closure is empty, or complete the implementation.”

Andrei Solovev added 17 commits May 27, 2024 13:20
…Closure

Fix SonarCloud Empty Closure warning
Fix SonarCloud "Cognitive Complexity" warning in BadRequestReason
Fix SonarCloud "Cognitive Complexity" warning in CreditCardPaymentController
…DateTextField

Fix SonarCloud "Cognitive Complexity" warning in CardExpiryDateTextField
…oller

Fix SonarCloud "Cognitive Complexity" warning in NetceteraThreeDSController
Fix SonarCloud "Cognitive Complexity" warning in OmiseError's BadRequestReason (2)
@vault087 vault087 changed the title [Draft] Develop -> Master Develop -> Master (SonarCloud Warnings Fixes) Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant