[Don't merge] Swap out gold sample for APOGEE DR17 unimodal sample (beta) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah ok maybe CI only runs the style check on PRs, so this won't work. Oh well! |
|
Alas none of these figures get generated via CI yet (it's currently implemented in Untitled32.ipynb...) I'll try this or share the relevant data file soon! |
|
Here's the xmatch for this sample (note that the normalized residuals histogram does not include the reported APOGEE uncertainties):
|
|
beautiful! |
|
PS I will have a new, "official" DR17 unimodal sample soon (weeks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of what will be the gold sample for the upcoming APOGEE data release (DR17). The MAP parameter values may be a little off here because I had some issues getting the MCMC sampling to work for all of the systems, but it is ~2x as many sources as the previous catalog, so I'm interested to see how things look! Since this is a beta version, we shouldn't switch to this for production, but hoping that CI will produce the figure I want to see 🙏?