[SYCLomatic-test]Add test for cublaslt macro #838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Nov 27, 2024
|
|
||
| // create host memory of random numbers | ||
| float* out = (float*)malloc(B * T * OC * sizeof(float)); | ||
| float* inp = make_random_float(B * T * C); |
Contributor
There was a problem hiding this comment.
- there is no definitaion of
make_random_float. - I prefer using fixed input than using random input. Fixed input => fixed output is more convenient to compare the result in cuda and sycl.
zhiweij1
reviewed
Nov 27, 2024
| cudaCheck(cudaMemcpy(d_inp, inp, B * T * C * sizeof(float), cudaMemcpyHostToDevice)); | ||
| cudaCheck(cudaMemcpy(d_weight, weight, C * OC * sizeof(float), cudaMemcpyHostToDevice)); | ||
| cudaCheck(cudaMemcpy(d_bias, bias, OC * sizeof(float), cudaMemcpyHostToDevice)); | ||
| matmul_forward(out, inp, weight, bias, B, T, C, OC); |
Contributor
There was a problem hiding this comment.
Please also check the output result. (Prepare reference data, compare the output with the reference data.)
zhiweij1
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR oneapi-src/SYCLomatic#2436
@zhiweij1 @zhimingwang36