[SYCLomatic] Enable Migration of meta_group_size() #2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShengchenJ
approved these changes
Oct 25, 2024
zhimingwang36
approved these changes
Nov 6, 2024
abhilash1910
force-pushed
the
meta_group
branch
from
b9d0623 to
6753193
Compare
abhilash1910
force-pushed
the
meta_group
branch
from
83820e9 to
6212331
Compare
ShengchenJ
approved these changes
Nov 18, 2024
abhilash1910
force-pushed
the
meta_group
branch
from
ae8b88b to
9c1e9db
Compare
ShengchenJ
requested changes
Nov 26, 2024
| cg::tiled_partition<2>(block).meta_group_size(); | ||
| // CHECK: catile2.get_local_linear_range(); | ||
| catile2.meta_group_size(); | ||
| // CHECK: atile2.get_local_linear_range(); |
Contributor
There was a problem hiding this comment.
the meta_group_size means the group number after the partition in the CUDA docs(https://docs.nvidia.com/cuda/cuda-c-programming-guide/#coalesced-groups) but get_local_linear_range means the size of the work items in partitioned group.
Contributor
Author
There was a problem hiding this comment.
Yes mapping is changed. Please review , thanks
ShengchenJ
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in llm.c
warp.meta_group_size()
cc @ShengchenJ @zhimingwang36 @yihanwg