[SYCLomatic] Add braces around kernel call that use root-group #2398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // CHECK-NEXT: exp_props, [=](sycl::nd_item<3> item_ct1) { | ||
| // CHECK-NEXT: kernel(item_ct1); | ||
| // CHECK-NEXT: }); | ||
| // CHECK-NEXT: } |
Contributor
There was a problem hiding this comment.
if there is only one kernel in the code block, then no need to insert {}.
| int main() { | ||
| // CHECK: auto exp_props = sycl::ext::oneapi::experimental::properties{sycl::ext::oneapi::experimental::use_root_sync}; | ||
| // CHECK: { | ||
| // CHECK-NEXT: auto exp_props = sycl::ext::oneapi::experimental::properties{sycl::ext::oneapi::experimental::use_root_sync}; |
Contributor
There was a problem hiding this comment.
can we inline the exp_props in parallel_for?
| int main() { | ||
| // CHECK: auto exp_props = sycl::ext::oneapi::experimental::properties{sycl::ext::oneapi::experimental::use_root_sync}; | ||
| // CHECK: { | ||
| // CHECK-NEXT: auto exp_props = sycl::ext::oneapi::experimental::properties{sycl::ext::oneapi::experimental::use_root_sync}; |
Contributor
There was a problem hiding this comment.
How about insert the exp_pros when on demand? In this case, it is not required.
ziranzha
approved these changes
Nov 8, 2024
Signed-off-by: Wang, Yihan <[email protected]>
yihwang-nv
force-pushed
the
fix_braces
branch
from
eb207ff to
c6eb0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.