-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeviceAsan] Symbolizer may destruct before SanitizerInterceptor #2237
base: main
Are you sure you want to change the base?
[DeviceAsan] Symbolizer may destruct before SanitizerInterceptor #2237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
e42beea
to
621cb2b
Compare
Hi @pbalcer , we have another internal discussion and we still think having a symbolizer within the context is strange and we don't want that. Instead, we will construct a symbolizer each time we try to use it. Symbolization happened in the error reporting stage and we don't think performance is a problem at that stage. By doing so we won't have the symbolizer in the context and won't have the destruction order problem too. |
Sure, makes sense. Another option could be using the |
… into yc/1024-devasan-bug-symbolizer-destruct-too-early
We may try to use symbolizer in the destructor of SanitizerInterceptor, but since we are using a static Symbolizer, we cannot control it's destruction order and it can be destructed before SanitizerInterceptor layer. This patch tries to manually let the Symboilzer destruct at the very end of the exit process.