Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: clear and delete command and add husky hooks #30

Merged
merged 18 commits into from
Jan 18, 2022
Merged

Feat: clear and delete command and add husky hooks #30

merged 18 commits into from
Jan 18, 2022

Conversation

robertoHeCi
Copy link
Contributor

What’s the focus of this PR

  • Create the clear and delete command
  • Add husky hooks using the way suggested for the new version

How to review this PR

  • Check our the branch
  • Run npm run test

Related work items

Before submitting this PR, I made sure:

  • The code builds clean without any errors or warnings
  • I've added tests

Íñigo Marquínez Prado and others added 18 commits September 8, 2021 15:18
fix: readme
fdcc809
feat: added new clearAndDelete command
831736d
feat: added custom client logic to commandExecutor
50488f2
test: add a frozen version of local stack
09f8b2d
test: fix new index implementation and add test to cover it
c9c47f2
chore wip
c09905d
feat: add the right client to the custom command fx
bd9bada
test: add jest flags to improve test running process
5aa968c
feat; create first custom command
d218ef9
test: update command executor test
7db2bde
refactor: improve clear and delete tests
ec6ea25
chore: fix merge conflicts
4ac6565
feat: remove prepare script and add husky validations
1c4e63b
refactor: apply eslint rules
dfb0548
feat: add husky through json file
424b9e0
refactor: use .husky folder instead of json file
251e9af
feat: add husky pre commit hook
5fea32b
feat: add husky pre push hook
8bce40b
inigomarquinez
inigomarquinez approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some comments added to remember what to include as future issues / tasks.

commands/custom/clearAndDelete.js Show resolved Hide resolved
package.json Show resolved Hide resolved
@inigomarquinez inigomarquinez merged commit 4c06c7e into main Jan 18, 2022
@inigomarquinez inigomarquinez deleted the clear-and-delete-command branch January 18, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inigomarquinez inigomarquinez inigomarquinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertoHeCi @inigomarquinez