chore(renovate-config)!: update config home-operations/renovate-presets (5.0.0 ➔ 6.0.0) - #11490
Merged
Conversation
…ts (5.0.0 ➔ 6.0.0) Upstream moved the app-specific presets out of managers/ and versioning/ into an opt-in apps/ directory. Nested preset references carry no tag, so they resolve from the default branch regardless of the pin, and 5.0.0 default.json kept asking for managers/cnpg.json5 after it moved. Opt back into the two apps/ presets this repo needs: grafanaDashboards for the grafanadashboard.yaml manifests and talosFactory for the factory.talos.dev installer image. Signed-off-by: Devin Buhl <devin@buhl.casa>
Contributor
konflate — summaryNote ✅ No rendered changes. konflate · rendered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11489
Why
The
#5.0.0pin only pinned the entry point.default.jsonat that tag lists its nested presets without a tag, and Renovate resolves each nested reference from the preset repo's default branch. home-operations/renovate-presets#86 moved the app-specific presets out ofmanagers/andversioning/into an opt-inapps/directory, sodefault.json@5.0.0kept asking formanagers/cnpg.json5, which no longer exists on main. Preset resolution failed and Renovate halted every PR.What
Bump to
6.0.0, whosedefault.jsonmatches the new layout, and explicitly opt into the twoapps/presets this repo actually needs:apps/grafanaDashboards.json5- 13grafanadashboard.yamlmanifests underkubernetes/apps/, plus the existing auto-merge rule that matches thecustom.grafana-dashboardsdatasource.apps/talosFactory.json5- thefactory.talos.devinstaller image intalos/cluster.yaml.j2, and the rule that stops the generic Docker manager from double-matching it.cnpg,llamacpp,phanpyandsearxngalso moved but are unused here, so they stay out.Verification
Ran
renovate --platform=local --dry-run=lookupagainst a fixture holding this config,talos/cluster.yaml.j2and agrafanadashboard.yaml:mainreproduces the exact issue error:Cannot find preset's package (github>home-operations/renovate-presets//managers/cnpg.json5).siderolabs/talosv1.14.0-beta.1viacustom.talos-factory, and dashboard13524rev1viacustom.grafana-dashboards.