Make CPE matching case insensitive #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonilles
reviewed
Nov 15, 2024
kissgyorgy
force-pushed
the
fix-matching-case
branch
2 times, most recently
from
64c35ae to
e2a37e5
Compare
For a seamless developer experience - Follows nixpkgs-unstable - Python 3.11 because that's what we are using internally everywhere
We need to test all supported versions. Use poetry with separate virtualenvs for all in .venvs/ Ruff UP rules had to be disabled to allow for old typing syntax.
We don't use it and I don't know the use-case for it. This simplifies public API for the library.
type hints and make CPE matching more readable. No logical change, everything should work the same as before.
According to Common Platform Enumeration: Naming Specification Version 2.3 Section 2.3 and Common Platform Enumeration: Name Matching Specification Version 2.3 Section 7.3 and 6.1.3.2 CPE attributes should be lowercased before comparing them. In practice, all CPEs in the CVE Database are in lowercase, that shouldn't be a problem, but comparing with user input (like CPE coming from an SBOM) should work according to the specification.
kissgyorgy
force-pushed
the
fix-matching-case
branch
from
e2a37e5 to
249fb8f
Compare
Use the same ruff version as for devenv, so results will be the same in CI as locally. Updated deprecated ruff options.
kissgyorgy
force-pushed
the
fix-matching-case
branch
from
249fb8f to
2aa8a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Common Platform Enumeration: Naming Specification Version 2.3 Section 2.3
and
Common Platform Enumeration: Name Matching Specification Version 2.3 Section 7.3 and 6.1.3.2,
CPE attributes should be lowercased before comparing them.
In practice, all CPEs in the CVE Database are in lowercase, that shouldn't be a problem, but comparing with user input (like CPE coming from an SBOM) should work according to the specification.