Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sonatype publish #4

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Test sonatype publish #4

merged 7 commits into from
Nov 21, 2023

Conversation

kevin-delmas
Copy link
Collaborator

Set up sonatype publishing process based on SBT
Add some basic tests

@kevin-delmas kevin-delmas added bug Something isn't working enhancement New feature or request labels Nov 13, 2023
@kevin-delmas kevin-delmas self-assigned this Nov 13, 2023
@kevin-delmas kevin-delmas linked an issue Nov 13, 2023 that may be closed by this pull request
@Gaudeval
Copy link
Collaborator

Gaudeval commented Nov 13, 2023

I do not think we have a pull request template but check whatever applies:

  • Is the change a minor version, or will compatibility changes require a new major release?
  • Is the change linked to an existing pull request ?
  • To the best of my knowledge, this compiles/has been tested/works
  • Any refactoring has been safely handled by my IDE
    🦆

@Gaudeval
Copy link
Collaborator

As we are getting to grips with the tools (it has been a while), I am trying comments, reviews, and tasks to see which impact the review requirements or not. Just shout at me if this should have been through already.

@kevin-delmas
Copy link
Collaborator Author

As we are getting to grips with the tools (it has been a while), I am trying comments, reviews, and tasks to see which impact the review requirements or not. Just shout at me if this should have been through already.

Please do, let's explore the amazing possibilities of the tool

@kevin-delmas
Copy link
Collaborator Author

I do not think we have a pull request template but check whatever applies:

  • Is the change a minor version, or will compatibility changes require a new major release?
  • Is the change linked to an existing pull request ?
  • To the best of my knowledge, this compiles/has been tested/works
  • Any refactoring has been safely handled by my IDE
    🦆

An template we can reuse is available here.
@Gaudeval what do you think of that ?

@kevin-delmas
Copy link
Collaborator Author

kevin-delmas commented Nov 17, 2023

I do not think we have a pull request template but check whatever applies:

  • Is the change a minor version, or will compatibility changes require a new major release?
  • Is the change linked to an existing pull request ?
  • To the best of my knowledge, this compiles/has been tested/works
  • Any refactoring has been safely handled by my IDE
    🦆

You can check the .github/pull_request_template.md

Copy link
Collaborator

@Gaudeval Gaudeval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments are related to documentation updates, to be covered by issue #6. All functional aspects are go. And it should be merged.

@Gaudeval
Copy link
Collaborator

@kevin-delmas I will let you the honour of merging your PR.

@kevin-delmas kevin-delmas merged commit f035b69 into master Nov 21, 2023
@kevin-delmas kevin-delmas deleted the testSonatypePublish branch November 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package naming convention
2 participants