-
Notifications
You must be signed in to change notification settings - Fork 0
Add ca CLI prototype #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@codex review this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 255e1a1baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sources/Ca/ConfigLoader.swift
Outdated
| #if os(macOS) | ||
| if #available(macOS 15, *) { | ||
| return await loadWithConfiguration() | ||
| } | ||
| return .default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config file ignored on macOS 13/14
The new config loader only attempts to read ~/.config/ca/config.json when running on macOS 15 or newer; otherwise it returns .default immediately. Because the project still supports macOS 13+ (per repo docs), any user on macOS 13 or 14 will have their ca config silently ignored and the CLI will always use defaults, unlike Linux where configs load. This breaks the advertised config-based customization on supported macOS versions.
Useful? React with 👍 / 👎.
Summary
caexecutable target with config loading, syntax highlighting, and pagingTesting