Replace magic number with constant

onflow · Oct 2, 2023 · f3fdb2d · f3fdb2d
1 parent 90be7ac
commit f3fdb2d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/array.go b/array.go
@@ -89,6 +89,8 @@ const (
 		inlinedCBORValueIDHeadSize +
 		inlinedValueIDSize +
 		arrayDataSlabElementHeadSize
+
+	maxInlinedExtraDataIndex = 255
 )
 
 type ArraySlabHeader struct {
@@ -697,9 +699,9 @@ func (a *ArrayDataSlab) encodeAsInlined(enc *Encoder, inlinedTypeInfo *inlinedEx
 
 	extraDataIndex := inlinedTypeInfo.addArrayExtraData(a.extraData)
 
-	if extraDataIndex > 255 {
+	if extraDataIndex > maxInlinedExtraDataIndex {
 		return NewEncodingError(
-			fmt.Errorf("failed to encode inlined array data slab: extra data index %d exceeds limit 255", extraDataIndex))
+			fmt.Errorf("failed to encode inlined array data slab: extra data index %d exceeds limit %d", extraDataIndex, maxInlinedExtraDataIndex))
 	}
 
 	var err error

diff --git a/map.go b/map.go
@@ -2820,8 +2820,8 @@ func (m *MapDataSlab) encodeAsInlinedMap(enc *Encoder, inlinedTypeInfo *inlinedE
 
 	extraDataIndex := inlinedTypeInfo.addMapExtraData(m.extraData)
 
-	if extraDataIndex > 255 {
-		return NewEncodingError(fmt.Errorf("extra data index %d exceeds limit 255", extraDataIndex))
+	if extraDataIndex > maxInlinedExtraDataIndex {
+		return NewEncodingError(fmt.Errorf("extra data index %d exceeds limit %d", extraDataIndex, maxInlinedExtraDataIndex))
 	}
 
 	var err error
@@ -2885,9 +2885,9 @@ func encodeAsInlinedComposite(
 		return NewEncodingError(fmt.Errorf("number of elements %d is different from number of elements in cached composite type %d", len(keys), len(cachedKeys)))
 	}
 
-	if extraDataIndex > 255 {
+	if extraDataIndex > maxInlinedExtraDataIndex {
 		// This should never happen because of slab size.
-		return NewEncodingError(fmt.Errorf("extra data index %d exceeds limit 255", extraDataIndex))
+		return NewEncodingError(fmt.Errorf("extra data index %d exceeds limit %d", extraDataIndex, maxInlinedExtraDataIndex))
 	}
 
 	var err error