Pin dependencies in ci.yml #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin dependencies: - actions/setup-go - actions/checkout Bump go versions tested to go-1.19 and go-1.20.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 64.93% 64.95% +0.02%
==========================================
Files 14 14
Lines 8811 8811
==========================================
+ Hits 5721 5723 +2
+ Misses 2356 2354 -2
Partials 734 734 ☔ View full report in Codecov by Sentry. |
Fix Go version 1.20 being interpreted as 1.2 by using quotes.
ramtinms
approved these changes
Mar 11, 2024
| @@ -31,17 +31,17 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [macos-latest, ubuntu-latest] | |||
| go-version: [1.17, 1.18, 1.19] | |||
| go-version: [1.19, '1.20'] | |||
There was a problem hiding this comment.
Interesting, using string format instead of value.
There was a problem hiding this comment.
Yeah, the quotes around 1.20 prevents .yml parser interpreting 1.20 as 1.2 which can cause weird errors!
I ran into this in another repo and it took time to debug because I didn't notice go1.20 -> go1.2 right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mainbranchFiles changedin the Github PR explorer