Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OrderedMap.SetType() to allow updating TypeInfo #375

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Mar 5, 2024

Closes #373

This feature is needed by Cadence migrations to update static types. For more details, see

This PR allows updating static types of OrderedMap container.


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added enhancement New feature or request E&V Team Execution / Verification / Edge Team labels Mar 5, 2024
@fxamacker fxamacker self-assigned this Mar 5, 2024
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for adding this!

Same feedback as for the related PR, #374

@fxamacker fxamacker force-pushed the fxamacker/add-map-settype branch from 998fb49 to 8e77472 Compare March 8, 2024 15:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (e1a76d5) to head (8e77472).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence     #375      +/-   ##
==========================================================
+ Coverage                   66.03%   66.09%   +0.06%     
==========================================================
  Files                          14       14              
  Lines                        8225     8233       +8     
==========================================================
+ Hits                         5431     5442      +11     
+ Misses                       2115     2113       -2     
+ Partials                      679      678       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fxamacker fxamacker merged commit dc825c2 into feature/stable-cadence Mar 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E&V Team Execution / Verification / Edge Team enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants